feat: button website icon #8591

tataihono · 2026-01-13T23:01:11Z

Add the 'Website' icon option to button leading/trailing icon selectors for admins.

Linear Issue: NES-1206

Summary by CodeRabbit

New Features
- Added a new "Website" icon option (LanguageRounded) available for selection across the editor and UI.
- Backend API schemas updated to recognize the new icon name so it can be used throughout the application.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

- Add LanguageRounded to GraphQL IconName enum - Update Icon component in journeys-ui to support LanguageRounded - Add Website option to Icon selector in journeys-admin - Update all generated GraphQL types Resolves NES-1206

cursor · 2026-01-13T23:01:12Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

linear · 2026-01-13T23:01:14Z

NES-1206 Add website icon to next steps

coderabbitai · 2026-01-13T23:01:17Z

Walkthrough

Added a new IconName enum member LanguageRounded, imported the Material-UI icon, and registered it in UI icon maps and admin icon selection so the new icon is available across schemas and components.

Changes

Cohort / File(s)	Summary
GraphQL Schema Updates `apis/api-gateway/schema.graphql`, `apis/api-journeys-modern/schema.graphql`, `apis/api-journeys/schema.graphql`, `apis/api-journeys/src/app/modules/block/icon/icon.graphql`	Added `LanguageRounded` to the `IconName` enum in four GraphQL schema files.
Admin UI icon list `apps/journeys-admin/src/components/Editor/Slider/Settings/CanvasDetails/Properties/controls/Icon/Icon.tsx`	Imported `LanguageRounded` from `@mui/icons-material/LanguageRounded` and appended an icons array entry with `value: IconName.LanguageRounded`, `label: t('Website')`, and `display: <LanguageRounded />`.
Shared Icon component `libs/journeys/ui/src/components/Icon/Icon.tsx`	Imported `LanguageRounded` and added it to the Icon component’s icon map so it can be rendered by `iconName`.
Minor import reorder `libs/journeys/ui/src/components/Step/Step.tsx`	Reordered one import (`useGetValueFromJourneyCustomizationString`) without functional changes.

Sequence Diagram(s)

sequenceDiagram
  actor AdminUI as Admin UI (Editor)
  participant IconComp as Shared Icon Component
  participant GraphQL as GraphQL APIs
  participant DB as Database

  AdminUI->>IconComp: User selects IconName.LanguageRounded
  IconComp-->>AdminUI: render <LanguageRounded /> preview
  AdminUI->>GraphQL: Save block with iconName: LanguageRounded (mutation)
  GraphQL->>DB: persist iconName value
  DB-->>GraphQL: confirm saved
  GraphQL-->>AdminUI: mutation response (saved block)
  AdminUI->>IconComp: request render for saved block (iconName: LanguageRounded)
  IconComp-->>AdminUI: render <LanguageRounded />

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix: add/fix missing translations #7594 — Modifies the same admin icons array (label/translation fixes); strongly related to icon list changes.
feat: template aggregate stats #8541 — Also adds/updates icons and IconName enum entries across UI and schemas.
feat: edit event label #8566 — Updates icon definitions and mappings similar to this change.

Suggested reviewers

jianwei1
mikeallisonJS
tanflem

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: button website icon' directly summarizes the main change—adding a website icon option to button icon selectors across the codebase.
Linked Issues check	✅ Passed	The pull request implements all coding requirements from NES-1206: backend GraphQL schema updates across three API files, icon component registration in two UI libraries, and admin UI integration for website icon selection.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to adding the LanguageRounded website icon support. The reordering of imports in Step.tsx is a minor organizational change that maintains the same functionality and does not introduce unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cursor/NES-1206-button-website-icon-36fd

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 58951cc and 504d2ef.

⛔ Files ignored due to path filters (2)

apps/journeys-admin/__generated__/JourneyVisitorExportToGoogleSheet.ts is excluded by !**/__generated__/**
libs/shared/gql/src/__generated__/graphql-env.d.ts is excluded by !**/__generated__/**

📒 Files selected for processing (1)

libs/journeys/ui/src/components/Step/Step.tsx

✅ Files skipped from review due to trivial changes (1)

libs/journeys/ui/src/components/Step/Step.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

GitHub Check: test (22, 2/3)
GitHub Check: Analyze (javascript)
GitHub Check: test (22, 1/3)
GitHub Check: test (22, 3/3)
GitHub Check: build (22)
GitHub Check: lint (22)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-01-13T23:02:29Z

View your CI Pipeline Execution ↗ for commit 504d2ef

Command	Status	Duration	Result
`nx run journeys-e2e:e2e`	✅ Succeeded	45s	View ↗
`nx run videos-admin-e2e:e2e`	✅ Succeeded	6s	View ↗
`nx run short-links-e2e:e2e`	✅ Succeeded	5s	View ↗
`nx run journeys-admin-e2e:e2e`	✅ Succeeded	2m 18s	View ↗
`nx run watch-e2e:e2e`	✅ Succeeded	26s	View ↗
`nx run resources-e2e:e2e`	✅ Succeeded	23s	View ↗
`nx run player-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run-many --target=vercel-alias --projects=jo...`	✅ Succeeded	2s	View ↗
`Additional runs (20)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-13 23:25:00 UTC

github-actions · 2026-01-13T23:05:03Z