Skip to content

RGB30 improvements + theme color XML refactoring + video/detailed view differentiation#2

Open
taoquay wants to merge 5 commits intoJetup13:masterfrom
taoquay:master
Open

RGB30 improvements + theme color XML refactoring + video/detailed view differentiation#2
taoquay wants to merge 5 commits intoJetup13:masterfrom
taoquay:master

Conversation

@taoquay
Copy link

@taoquay taoquay commented Dec 14, 2023

This PR started out as a few layout fixes for overlapping text in the metadata of the detailed/video views I noticed on the RGB30, but while working on it, I implemented more changes along the way. Here is a list of changes:

  1. In video/detailed view, the metadata values were overlapping with the labels by a few pixels. I created a separate RGB30 detailed view style, since I didn't want to impact existing devices that don't have a 1:1 display. With the additional vertical space of the RGB30, I added the "last played" field, since there was enough space for it.
  2. Most of the theme color XML files are very similar, with a lot of duplicated code. I refactored it by moving the common code directly to themes.xml. This change makes it much easier to change the format of the release date, as we no longer need to modify the %Y line in each of the 20 color themes, and can do it only once from themes.xml.
  3. The video and detailed views appear to be identical in function. I made the detailed view different by disabling the video playback, so it only displays the 2D box art. With this change, there is an actual distinction between the video and detailed views.

I did some regression testing to check that I didn't break anything with the refactoring of the XML from the changes and everything looks to be OK to me.

I'm open to discuss or apply changes to the PR if need be. In particular, as I only have a RGB30, I don't know if the overlapping text with the metadata is specific to the RGB30, or if other devices with 4:3, 3:2 or 16:9 aspect ratios also have the problem. I can apply the fix to the regular withmeta.xml file, if the overlapping text issue is not specific to the RGB30.

…to theme.xml

This change allows changing the format of the release date without needing to modify each of the 20 color variations individually.
This additional view fixes overlapping pixels between metadata labels and values. Also adds a "Last played" field with the available additional vertical space on the RGB30.
… it from video gamelist view

In the existing implementation, both video and detailed gamelist view styles seemed to be identical in function. This commit makes the detailed view only show the box art, without playing video. The video view stays the same (shows box art and then starts playing video a few seconds later).
2. Rename RGB30 gamelist menu name
3. Set metadata color to secondaryColor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant