RGB30 improvements + theme color XML refactoring + video/detailed view differentiation#2
Open
taoquay wants to merge 5 commits intoJetup13:masterfrom
Open
RGB30 improvements + theme color XML refactoring + video/detailed view differentiation#2taoquay wants to merge 5 commits intoJetup13:masterfrom
taoquay wants to merge 5 commits intoJetup13:masterfrom
Conversation
…to theme.xml This change allows changing the format of the release date without needing to modify each of the 20 color variations individually.
This additional view fixes overlapping pixels between metadata labels and values. Also adds a "Last played" field with the available additional vertical space on the RGB30.
… it from video gamelist view In the existing implementation, both video and detailed gamelist view styles seemed to be identical in function. This commit makes the detailed view only show the box art, without playing video. The video view stays the same (shows box art and then starts playing video a few seconds later).
2. Rename RGB30 gamelist menu name 3. Set metadata color to secondaryColor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started out as a few layout fixes for overlapping text in the metadata of the detailed/video views I noticed on the RGB30, but while working on it, I implemented more changes along the way. Here is a list of changes:
I did some regression testing to check that I didn't break anything with the refactoring of the XML from the changes and everything looks to be OK to me.
I'm open to discuss or apply changes to the PR if need be. In particular, as I only have a RGB30, I don't know if the overlapping text with the metadata is specific to the RGB30, or if other devices with 4:3, 3:2 or 16:9 aspect ratios also have the problem. I can apply the fix to the regular
withmeta.xmlfile, if the overlapping text issue is not specific to the RGB30.