Skip to content

Comments

feat: Add support for repository name with dots#14

Open
xakraz wants to merge 4 commits intoJno21:mainfrom
DataDome-OSS-contrib:patch-1
Open

feat: Add support for repository name with dots#14
xakraz wants to merge 4 commits intoJno21:mainfrom
DataDome-OSS-contrib:patch-1

Conversation

@xakraz
Copy link

@xakraz xakraz commented Jan 8, 2026

This pull request makes two main improvements: it enhances the repository URL parsing logic to handle .git suffixes more robustly, and it ensures the build step runs automatically when installing the package from a git repository by adding a prepare script.

Build process improvements:

  • Added a prepare script to package.json so that npm run build is executed automatically on install, which is important for users installing directly from git.

Repository URL parsing enhancements:

  • Updated the parseRepositoryUrl function in src/utils.ts to properly handle repository URLs with a .git suffix by stripping it before parsing, improving compatibility with various URL formats.

Copilot AI review requested due to automatic review settings January 8, 2026 14:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for parsing repository URLs that contain dots in the repository name. The implementation moves the .git suffix removal to occur before URL pattern matching, allowing repository names with dots to be correctly parsed.

Key Changes:

  • Moved .git suffix removal from the end of parsing to the beginning
  • Updated regex pattern to allow dots in repository names by removing the / and . character exclusion from the repository name capture group

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xakraz and others added 2 commits January 9, 2026 10:26
- Add "prepare" script to run build before publishing

Signed-off-by: Xavier Krantz <xakraz@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 9, 2026 09:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 9, 2026 10:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant