Skip to content

Comments

fix dw5 parsing temperature_pv#34

Merged
michaelosthege merged 1 commit intoJuBiotech:mainfrom
Djaygo:bugfix/v5_temperature_pv_parsing
Aug 13, 2025
Merged

fix dw5 parsing temperature_pv#34
michaelosthege merged 1 commit intoJuBiotech:mainfrom
Djaygo:bugfix/v5_temperature_pv_parsing

Conversation

@Djaygo
Copy link
Contributor

@Djaygo Djaygo commented Aug 4, 2025

I adjusted the regex, to work with Unit 1.T1.PV

#33

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Djaygo
Copy link
Contributor Author

Djaygo commented Aug 5, 2025

  • The JuBiotech maintainers know my real name.

At least one of the following two applies:

  • I am not making this contribution on behalf of my current employer.

@Djaygo
Copy link
Contributor Author

Djaygo commented Aug 5, 2025

I have read the CLA Document and I hereby sign the CLA.

@Djaygo
Copy link
Contributor Author

Djaygo commented Aug 5, 2025

recheck

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.53%. Comparing base (f0f5488) to head (ae37579).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files           7        7           
  Lines         308      308           
=======================================
  Hits          285      285           
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'm going to cut a release now.

@michaelosthege michaelosthege merged commit ce98d09 into JuBiotech:main Aug 13, 2025
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants