Drop AbstractFFT interface #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/realreal
branch
3 times, most recently
from
aeaae2f to
655cc5f
Compare
Closed
andreasnoack
force-pushed
the
an/noabstract
branch
2 times, most recently
from
e7295ba to
7c1b982
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 98.04% 98.09% +0.04%
==========================================
Files 4 5 +1
Lines 409 419 +10
==========================================
+ Hits 401 411 +10
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreasnoack
force-pushed
the
an/noabstract
branch
from
7c1b982 to
2cae769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just to demonstrate what it would take to drop
AbstractFFTs, ref #77. If we take this route, then we might want to consider other adjustments as discussed in #77. I think it will also make it easier to set up documentation for our methods.