Fix missing config for revamped Reliant and Swivel#128
Open
scarf005 wants to merge 1 commit intoKSP-RO:masterfrom
Open
Fix missing config for revamped Reliant and Swivel#128scarf005 wants to merge 1 commit intoKSP-RO:masterfrom
scarf005 wants to merge 1 commit intoKSP-RO:masterfrom
Conversation
Author
|
@Capkirk123 sorry for pinging, but could this PR be taken a look? thank you for your time. |
Member
|
I don't know that we even still support this? I don't have permission to edit it at least. I can see if I can get someone to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Reliant and Swivel engines were revamped in version 1.12.2.
This changed their part name from:
liquidEnginetoliquidEngine_v2(reliant)liquidEngine2toliquidEngine2_v2(swivel)since realplume stock configs are loading
liquidEngineandliquidEngine2, this makes realplume configs not load for revamped engines.Summary of changes
This commit adds two missing realplume configs for:
Everything else is identical.