Questpatches #86
Merged
Questpatches #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxtorCoder
requested changes
May 14, 2025
MaxtorCoder
reviewed
May 15, 2025
Doug-Murphy
approved these changes
May 16, 2025
| } | ||
| catch (Exception ex) | ||
| { | ||
| Logger.Error("Failed during SaveManager_Save_Postfix execution.\n" + ex); |
There was a problem hiding this comment.
We should consider adding an overload in the Log class that takes in the exception and logs it using the built-in overloads that also take in the exceptions.
But it does seem that there's only an overload for the exception signature with Melon. Shame.
Doug-Murphy
approved these changes
May 16, 2025
| // ✅ Save only non-vanilla modded quests | ||
| foreach (Quest quest in QuestManager.Quests) | ||
| { | ||
| if (!quest.GetType().Namespace.StartsWith("ScheduleOne")) |
There was a problem hiding this comment.
Nit: Since the foreach loop is only doing this one thing and only against one type of thing, you could simplify it with foreach (Quest quest in QuestManager.Quests.Where(q => !q.GetType().Namespace.StartsWith("ScheduleOne")) to remove the if. This would also mean that you're looping over fewer things.
Nit in this case because I'm sure it's a very small collection, but good to keep in mind for future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.