Vehicles

[k073l]

Add a simple way to spawn and customize vehicles with S1API.

Example:

using S1API.Vehicles;

var vehicle = new LandVehicle("veeper");
vehicle.TopSpeed = 100f;
vehicle.Color = VehicleColor.Cyan;
vehicle.IsPlayerOwned = true;
vehicle.Spawn(new Vector3(0, 50, 0), Quaternion.identity);

[MaxtorCoder]

Re-order the access modifiers as well to how it looks like in the NPC class for example.

[MaxtorCoder]

Suggested change

	private void _setConnection()
	{
	var nm = InstanceFinder.NetworkManager;
	if (nm.IsClientOnly)
	{
	var tempConn = InstanceFinder.ClientManager.Connection;
	if (tempConn != null && tempConn.IsValid)
	_conn = tempConn;
	}
	else if (nm.IsServerOnly || (nm.IsServer && !nm.IsClient))
	{
	var owner = S1LandVehicle.Owner;
	if (owner != null && owner.IsValid)
	_conn = owner;
	}
	}
	private void SetConnection()
	{
	var nm = InstanceFinder.NetworkManager;
	if (nm.IsClientOnly)
	{
	var tempConn = InstanceFinder.ClientManager.Connection;
	if (tempConn != null && tempConn.IsValid)
	_conn = tempConn;
	}
	else if (nm.IsServerOnly || (nm.IsServer && !nm.IsClient))
	{
	var owner = S1LandVehicle.Owner;
	if (owner != null && owner.IsValid)
	_conn = owner;
	}
	}

[MaxtorCoder]

Suggested change

	private void _setIsPlayerOwned(bool isPlayerOwned)
	{
	S1LandVehicle.SetIsPlayerOwned(_conn, isPlayerOwned);
	// make sure to add/remove the vehicle from the player owned vehicles list
	if (isPlayerOwned)
	NetworkSingleton<S1Vehicles.VehicleManager>.Instance.PlayerOwnedVehicles.Add(S1LandVehicle);
	else
	NetworkSingleton<S1Vehicles.VehicleManager>.Instance.PlayerOwnedVehicles.Remove(S1LandVehicle);
	}
	private void SetIsPlayerOwned(bool isPlayerOwned)
	{
	S1LandVehicle.SetIsPlayerOwned(_conn, isPlayerOwned);
	// make sure to add/remove the vehicle from the player owned vehicles list
	if (isPlayerOwned)
	NetworkSingleton<S1Vehicles.VehicleManager>.Instance.PlayerOwnedVehicles.Add(S1LandVehicle);
	else
	NetworkSingleton<S1Vehicles.VehicleManager>.Instance.PlayerOwnedVehicles.Remove(S1LandVehicle);
	}

[MaxtorCoder]

Suggested change

	private void _setColor(VehicleColor color)
	{
	var setOwnedColorMethod =
	typeof(S1Vehicles.LandVehicle).GetMethod("SetOwnedColor",
	BindingFlags.Instance | BindingFlags.NonPublic);
	if (setOwnedColorMethod == null)
	{
	Logger.Error("SetOwnedColor method not found!");
	return;
	}
	setOwnedColorMethod.Invoke(S1LandVehicle, [_conn, (S1Vehicles.Modification.EVehicleColor)color]);
	}
	private void SetColor(VehicleColor color)
	{
	var setOwnedColorMethod =
	typeof(S1Vehicles.LandVehicle).GetMethod("SetOwnedColor",
	BindingFlags.Instance | BindingFlags.NonPublic);
	if (setOwnedColorMethod == null)
	{
	Logger.Error("SetOwnedColor method not found!");
	return;
	}
	setOwnedColorMethod.Invoke(S1LandVehicle, [_conn, (S1Vehicles.Modification.EVehicleColor)color]);
	}

[MaxtorCoder]

Suggested change

	private static readonly Log Logger = new Log("S1API.LandVehicle");
	private static readonly Log _logger = new Log("S1API.LandVehicle");

[MaxtorCoder]

Don't use the NetworkSingleton generic either. You can just call S1Vehicles.VehicleManager.Instance directly.

Should've been in the last one and I forgot, my bad.

[MaxtorCoder]

Thanks for the PR, I will fix any further issues with build :)