Skip to content

Conversation

@houseme
Copy link

@houseme houseme commented Jan 9, 2026

chore(deps): bump crypto deps; fix RSA prime=1 panic; update CI

  • Bump rsa to 0.9.10, aws-lc-rs to 1.15.2, p384 to 0.13.1, sha2 to 0.10.9,
    wasm-bindgen-test to 0.3.56, and ed25519-dalek to 2.2.0.
  • Fix: prevent panic in RSA crate when a prime equals 1 by adding proper
    validation and handling.
  • Update component version in ci.yml to reflect dependency changes.

cc @Keats #476

- Bump rsa to 0.9.10, aws-lc-rs to 1.15.2, p384 to 0.13.1, sha2 to 0.10.9,
  wasm-bindgen-test to 0.3.56, and ed25519-dalek to 2.2.0.
- Fix: prevent panic in RSA crate when a prime equals 1 by adding proper
  validation and handling.
- Update component version in `ci.yml` to reflect dependency changes.
Copilot AI review requested due to automatic review settings January 9, 2026 05:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cryptographic dependencies to their latest versions and includes CI workflow improvements. The RSA prime=1 panic fix mentioned in the PR title is addressed by upgrading the rsa crate to version 0.9.10, which contains the fix internally.

Key changes include:

  • Dependency updates: rsa (0.9.6→0.9.10), aws-lc-rs (1.10.0→1.15.2), p384 (0.13.0→0.13.1), sha2 (0.10.7→0.10.9), ed25519-dalek (2.1.1→2.2.0), and several dev dependencies
  • Code quality improvement in validation.rs using the #[default] attribute instead of manual Default implementation
  • GitHub Actions workflow updates (checkout v3→v6, setup-node v4→v6)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Bumps crypto and dev dependencies; updates feature syntax to use dep: prefix; increments version to 10.3.0
src/validation.rs Refactors Default trait implementation to use derive macro with #[default] attribute
benches/jwt.rs Updates black_box import to use std::hint instead of criterion for compatibility with criterion 0.7
CHANGELOG.md Documents version 10.3.0 release with dependency updates and RSA panic fix; removes trailing whitespace
.github/workflows/ci.yml Updates GitHub Actions versions (checkout v6, setup-node v6)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant