Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GraphemeString utility class that provides grapheme cluster-aware string operations for handling user-facing text. This is particularly important for correctly measuring the visual length of strings containing emoji, accented characters, and other complex Unicode sequences.
Changes:
- Adds
GraphemeStringclass insrc/lib/utils/grapheme-string.tswith comprehensive String API compatibility - Provides grapheme-aware alternatives to standard string methods (e.g.,
sliceGrapheme,concatGrapheme,trimGrapheme) - Includes extensive test suite covering emoji, normalization, international scripts, and edge cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/utils/grapheme-string.ts | New utility class implementing grapheme cluster-aware string operations using Intl.Segmenter |
| src/lib/utils/grapheme-string.test.ts | Comprehensive test suite with ~1900 lines covering constructor, string methods, Unicode normalization, emoji, international scripts, and edge cases |
ezraripps
approved these changes
Feb 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change provides support for a
GraphemeStringutility class for handling short user strings that they tend to think of as having a length equivalent to their visible length.