Open
Conversation
…at/contacts-storage-client
ezraripps
requested changes
Feb 26, 2026
Comment on lines
+15
to
+18
| export type ContactAddress = DistributiveOmit< | ||
| AssetTransferInstructions, | ||
| 'value' | 'assetFee' | 'totalReceiveAmount' | 'persistentAddressId' | ||
| >; |
Member
There was a problem hiding this comment.
Discussion::
Are we sure we want AssetTransferInstructions and not RecipientResolved with a separate field for the rails/location?
type ContactAddress = {
recepient: RecipientResolved;
location?: AssetLocationLike;
asset?: MovableAsset;
rail?: Rail; // or maybe multiple?
}
Comment on lines
+15
to
+18
| export type ContactAddress = DistributiveOmit< | ||
| AssetTransferInstructions, | ||
| 'value' | 'assetFee' | 'totalReceiveAmount' | 'persistentAddressId' | ||
| >; |
Member
There was a problem hiding this comment.
This does not support storing a username as a contact, this could be the address and maybe the provider id you got the username from. So it can be resolved to the users username
Contributor
Author
There was a problem hiding this comment.
How did you envision this structured?
…at/contacts-storage-client
…at/contacts-storage-client
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a contacts client that leverages the storage anchor.