Merged
Conversation
Contributor
Author
Contributor
Author
|
@echadwick-artist, @emackey: Can either of you take a quick look at this PR to make sure the model quality is good. The new models came from glTF-Sample-Models that had not been merged into this repo. |
Contributor
Author
|
All models have a new README with a listing of extensions used & required. Some models have updated Metadata file to better describe the license for that model Listing of new models
This PR will remain open until 4 Jan 2024 to allow people to comment (due to the holidays). |
Mention of "clearcoat" in the metadata is outdated. This asset uses anisotropy instead.
* Added all buffer targets. * Added Copyright and Generator fields to glTF. * Removed duplicate "screenshots" folder. * New textures and model to fix problems with UVs and bitmaps. * Added binary glTF. * Updated readme and screenshot, removed redundant images.
Contributor
|
The changes look good to me. I made a few changes to the models I worked on. Looked at a representative sampling of the MD files, the additions and fixes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added several new models that were unique to glTF-Sample-Models. Also updates to the generator program to include a list of model extensions (used and required).