Open
Conversation
To stress-test baked tangent-space normal bump maps.
Corrected spelling errors, and added a section on Source Textures.
* Blender examples added. * Binary files renamed for clarity. * Screenshot switched from glTF Sample Viewer to Babylon.js Sandbox, to demonstrate a successful rendering rather than a failed one. * Readme improvements.
Additional info added to the readme about tangents, and fixed a malformed link for MikkTSpace.
emackey
reviewed
Jan 5, 2024
Member
emackey
left a comment
emackey
left a comment
There was a problem hiding this comment.
This group of models looks really cool! It reminds me of the game "Portal."
|
|
||
| ## Tangent Space | ||
|
|
||
| Tangent space normal bump maps are often used in two ways: |
Member
There was a problem hiding this comment.
Can we remove the word "bump" here and throughout? I believe the proper name is "Tangent space normal map".
The terms "bump" and "bump map" are older and less well defined, often referring to height maps, displacement maps, and the like. Let's avoid saying "bump" here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To stress-test baked tangent-space normal bump maps.