Change skinned mesh warning to only consider transformed parent nodes#247
Merged
lexaknyazev merged 1 commit intoKhronosGroup:mainfrom Dec 28, 2025
Merged
Conversation
Member
|
The original warning also implicitly flags cases when the static transform is identity but the parent nodes are animated. This PR would reduce such coverage. We could instead reduce the severity of the original message and add a new warning that only flags static transforms (as these are clearly problematic). |
5a8896e to
43604cf
Compare
Contributor
Author
|
Done, the original message now has reduced severity, and a different message replaces it when the parent is transformed. |
Member
|
Please don't replace the original message when the new message is added. Seeing both messages upfront would be a better UX than seeing the parent transforms warning, fixing it, and discovering that the asset still has issues. |
43604cf to
e9af317
Compare
lexaknyazev
reviewed
Dec 28, 2025
lexaknyazev
reviewed
Dec 28, 2025
e9af317 to
d0bcf0a
Compare
d0bcf0a to
c6dca17
Compare
lexaknyazev
approved these changes
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
NODE_SKINNED_MESH_NON_ROOTwithNODE_SKINNED_MESH_PARENT_TRANSFORMSto avoid false positives for valid models. Fixes #133I believe this check more accurately reflects the purpose of the original check. It's not that parent-child relationships entirely are considered invalid, rather that the transform aspect of skinned mesh nodes is ignored with respect to the visible mesh. The test model
ignored_parent_transform.gltfis already set up this way, testing with a parent translated by[1, 2, 3]. There are valid use cases for inserting a skinned mesh into the hierarchy, for purposes like visibility, but we only need to validate for transforms.