Add full support for KHR_animation_pointer validation#248
Open
aaronfranke wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add full support for KHR_animation_pointer validation#248aaronfranke wants to merge 1 commit intoKhronosGroup:mainfrom
aaronfranke wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
53ffdcd to
8f388e9
Compare
8f388e9 to
547f1b4
Compare
Member
|
@aaronfranke I respect the efforts but certainly do not agree with the proposed implementation design. Going forward, please discuss non-trivial changes before proposing them. |
Contributor
Author
|
@lexaknyazev What is the alternative implementation design you propose? |
547f1b4 to
ab45b4e
Compare
Member
|
The implementation proposed in this PR has multiple issues such as: hard-coded and duplicated logic, suboptimal use of the validator's API, several unreachable and untested sections, etc. I have a quite different design drafted but not yet finished. May I borrow a few bits from this PR? This would speed up finishing that work. |
Contributor
Author
|
@lexaknyazev You may grab any code you want from this PR, or any future PR I make. Consider my work public domain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements and closes #198.
This PR finishes the work that PR #230 started, providing full support for validating
KHR_animation_pointer, including:EXT_lights_*extensions and theADOBE_materials_*extensions.