Conversation
| | `width` | `number` | Width of the rectangular light in meters. Must be a positive value. Required for `rect` lights, ignored for `disk` lights. | Conditional | `1.0` | | ||
| | `height` | `number` | Height of the rectangular light in meters. Must be a positive value. Required for `rect` lights, ignored for `disk` lights. | Conditional | `1.0` | | ||
| | `radius` | `number` | Radius of the disk light in meters. Must be a positive value. Required for `disk` lights, ignored for `rect` lights. | Conditional | `1.0` | |
There was a problem hiding this comment.
For consistency, it might be better to follow the punctual lights schema with shape-specific properties located in nested objects.
Alternatively:
- There might be a common property, e.g.,
size. The rectangular shape may then have arect.aspectRatioproperty while thediskshape wouldn't need anything else. - All these properties could be assumed as always being 1.0 and the actual size would always be controlled by node transforms.
There was a problem hiding this comment.
Great call. I'll make that change.
extensions/2.0/Vendor/EXT_lights_area/schema/light.area.schema.json
Outdated
Show resolved
Hide resolved
extensions/2.0/Vendor/EXT_lights_area/schema/light.area.schema.json
Outdated
Show resolved
Hide resolved
Added importing support for first version of EXT_light_area extension. KhronosGroup/glTF#2525
bghgary
left a comment
There was a problem hiding this comment.
Small comments. Do we need to discuss whether this extension should be EXT or KHR?
|
|
||
| Written against the glTF 2.0 spec. | ||
|
|
||
| ## Overview |
There was a problem hiding this comment.
Would it help to add a couple of pictures with an example of a rect and a disk in the real world for illustration purposes?
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
|
|
This is almost identical to the previously-proposed KHR area lights extension except that it excludes "sphere" as a valid shape in favour of only flat lights. (See #1948).