added more scaling and same seeds for student and teacher#18
Open
javiersgjavi wants to merge 1 commit intoKinyugo:mainfrom
Open
added more scaling and same seeds for student and teacher#18javiersgjavi wants to merge 1 commit intoKinyugo:mainfrom
javiersgjavi wants to merge 1 commit intoKinyugo:mainfrom
Conversation
Author
|
Maybe, to be more consistent with the implementation, c_in should be updated to be:
Any thoughts about that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made this small modification by making two small changes that may be affecting performance.
First, I have made sure that the same seed is being used before the teacher and student pass, so that the dropouts are exactly the same, as discussed in the iCT paper:
On the other hand, I have added scaling as I commented in the issue #7, in this case I have put the c_in that was seen in EDM repository and this repository and that is commented in the new openai paper:

For the sigma scaling, I have scaled it as described in EDM repository again.
I have not been able to run the notebook because of problems in my pc, but I hope there is no problem in the small implementation I have done.