StreamPlayer use TextToAudioStream queue instead of engine's one#232
StreamPlayer use TextToAudioStream queue instead of engine's one#232phamson02 wants to merge 2 commits intoKoljaB:masterfrom
Conversation
|
Thanks for this promising PR! I can’t merge it as-is, though, because of the changes to the def synthesize(self, text: str, audio_queue: queue.Queue) -> bool:This would require changes to the base class: Plus, every other engine would need its Also, could you add a test Python file in the Thanks again for your effort, much appreciated! |
|
Thanks for your nice words. I know that it would break things doing it that, but wanted to open this PR to illustrate a kinda hacky way that resolve my problem. Will come up with a small example for you to test this out later. |
|
Hey @KoljaB, sorry for the delay on the promised test for this PR. I didn't realise that I only need to make some changes to your FastAPI example. Pushed it here. |
|
Thank you for the test. Might take me a while to review, maybe one or two weeks. |
Illustrate a change that can resolve issue #230