added settings option for lighter note colors#9
Open
JVariance wants to merge 1 commit intoKumarManas04:masterfrom
Open
added settings option for lighter note colors#9JVariance wants to merge 1 commit intoKumarManas04:masterfrom
JVariance wants to merge 1 commit intoKumarManas04:masterfrom
Conversation
Author
|
Phew, finally made it. Thanks for your help via mail @KumarManas04 ! 😃 |
KumarManas04
requested changes
Jul 8, 2020
Owner
KumarManas04
left a comment
KumarManas04
left a comment
There was a problem hiding this comment.
Thanks for contributing but kindly make these changes:
- Please add '.idea' folder to .gitignore
- Raise PR to the 'contributions' branch and not the 'master' branch
- We cannot rearrange the indices of the colors because people already have notes in specific colors. So please revert the colors to their original order
- Since you are using a companion object to store the state of note color type, it will be destroyed on app restart and hence be reinstantiated to "dark". You can use persistence storage to store the current state.
From what I can understand (correct me if I am wrong) the colorsListLight and colorsListDark are sets of color which have versions of the colors for light and dark backgrounds. If so, we can make the color sets change automatically with the theme i.e. colorsListLight with light theme and colorsListDark with dark and AMOLED themes or vice-versa.
Please let me know your thoughts on this
KumarManas04
added
Feature Request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option into the settings to switch between darker and lighter note colors. @KumarManas04 this relates to the mail I sent you