Skip to content

Conversation

@amandasd
Copy link
Collaborator

No description provided.

@amandasd amandasd force-pushed the tc-detector-gpu-version branch 2 times, most recently from 3a18627 to 4fa3e7f Compare January 31, 2025 19:28
@amandasd amandasd requested a review from taobrienlbl February 10, 2025 18:48
@taobrienlbl taobrienlbl requested a review from ghweber February 10, 2025 19:27
           testing improvements for TELite features
           use a specific version via travis.yml
           require the library to be found
           output prints
           adding TELite installation
           removed the two executions with REQUIRE_NETCDF_MPI=FALSE
           updated TECA_DATA_REVISION
           updated TELite commit
@amandasd amandasd force-pushed the tc-detector-gpu-version branch from 9cd3358 to 03fc7de Compare February 13, 2025 01:08
@amandasd
Copy link
Collaborator Author

amandasd commented Mar 10, 2025

@taobrienlbl Where should I include the contents of cuCompactor.cuh?

@amandasd amandasd force-pushed the tc-detector-gpu-version branch 2 times, most recently from 2824f07 to a0214e9 Compare April 21, 2025 19:06
@amandasd amandasd force-pushed the tc-detector-gpu-version branch from a0214e9 to 4344293 Compare April 21, 2025 19:12
@amandasd amandasd force-pushed the tc-detector-gpu-version branch from 86af4e8 to 620fb44 Compare April 21, 2025 23:40
svn co svn://svn.code.sf.net/p/teca/TECA_data@${TECA_DATA_REVISION} TECA_data

# install TELite library
git clone https://github.com/LBL-EESA/TELite.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could I request that you add installation of TELite to TECA superbuild? https://github.com/lbl-eesa/teca_superbuild

Copy link
Collaborator Author

@amandasd amandasd May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I clone/install TELite under ${TECA_PREFIX}?

${TECA_PREFIX:=/global/common/software/m1517/teca/perlmutter_${PARTITION}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might be a useful interim step, but I do think that adding it to the superbuild would be good; but that doesn't have to block this PR from merging. I'll create another issue in teca_superbuild

Copy link
Collaborator Author

@amandasd amandasd May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating an issue in teca_superbuild. Sorry, I was not clear in my question. My question is where I should clone/install TELite in site/make_install_perlmutter_m1517.sh? However, I have other questions about it because I think there are other changes to do in teca_superbuild.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, yes, TECA_PREFIX

Copy link
Collaborator

@taobrienlbl taobrienlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Amanda! I have a few minor comments to address; once they're addressed and once you think this is ready, feel free to merge!

@amandasd amandasd force-pushed the tc-detector-gpu-version branch from a533eac to e744866 Compare May 6, 2025 18:57
amandasd added 2 commits May 29, 2025 14:56
…emory exhausted problem during the build stage for mpi4py on fedora
@taobrienlbl
Copy link
Collaborator

taobrienlbl commented Jul 8, 2025

@taobrienlbl Where should I include the contents of cuCompactor.cuh?

is this question still needing an answer?

Amanda: No, it was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants