-
Notifications
You must be signed in to change notification settings - Fork 22
Porting the DetectNodes/StitchNodes functions from TempestExtremes to TECA: CPU and GPU versions #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
3a18627 to
4fa3e7f
Compare
testing improvements for TELite features
use a specific version via travis.yml
require the library to be found
output prints
adding TELite installation
removed the two executions with REQUIRE_NETCDF_MPI=FALSE
updated TECA_DATA_REVISION
updated TELite commit
9cd3358 to
03fc7de
Compare
|
@taobrienlbl Where should I include the contents of cuCompactor.cuh? |
2824f07 to
a0214e9
Compare
…teca_tempest_tc_detect
a0214e9 to
4344293
Compare
added time_filter argument
fixed argument value
86af4e8 to
620fb44
Compare
| svn co svn://svn.code.sf.net/p/teca/TECA_data@${TECA_DATA_REVISION} TECA_data | ||
|
|
||
| # install TELite library | ||
| git clone https://github.com/LBL-EESA/TELite.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could I request that you add installation of TELite to TECA superbuild? https://github.com/lbl-eesa/teca_superbuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I clone/install TELite under ${TECA_PREFIX}?
${TECA_PREFIX:=/global/common/software/m1517/teca/perlmutter_${PARTITION}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that might be a useful interim step, but I do think that adding it to the superbuild would be good; but that doesn't have to block this PR from merging. I'll create another issue in teca_superbuild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating an issue in teca_superbuild. Sorry, I was not clear in my question. My question is where I should clone/install TELite in site/make_install_perlmutter_m1517.sh? However, I have other questions about it because I think there are other changes to do in teca_superbuild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, yes, TECA_PREFIX
taobrienlbl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great Amanda! I have a few minor comments to address; once they're addressed and once you think this is ready, feel free to merge!
a533eac to
e744866
Compare
…emory exhausted problem during the build stage for mpi4py on fedora
is this question still needing an answer? Amanda: No, it was deleted. |
…emory exhausted problem during the build stage for mpi4py on ubuntu
No description provided.