-
Notifications
You must be signed in to change notification settings - Fork 2
β¨ Add test-suite, add test workflow #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daniel Ruthardt <druthardt@linuxfoundation.org>
Signed-off-by: Daniel Ruthardt <druthardt@linuxfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive testing framework for Bash+ with container-based test isolation, assertion utilities, and CI/CD integration. The framework follows convention-based test discovery and provides visual feedback for test results.
- Implements a complete test suite with 9 assertion functions and test utilities
- Adds GitHub Actions workflow for automated testing with Docker container isolation
- Integrates test validation into the package publishing workflow to prevent releasing packages with failing tests
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
bashpt |
Test runner CLI that discovers and executes tests in Docker containers or locally |
libs/core/test/assert_success |
Assertion to verify commands exit with status 0 |
libs/core/test/assert_failure |
Assertion to verify commands exit with non-zero status |
libs/core/test/assert_equals |
Assertion to compare two values for equality |
libs/core/test/assert_exit_code |
Assertion to verify specific exit codes |
libs/core/test/assert_output |
Assertion to verify command stdout output |
libs/core/test/assert_contains |
Assertion to check if a string contains a substring |
libs/core/test/assert_not_contains |
Assertion to check if a string doesn't contain a substring |
libs/core/test/assert_command_exists |
Assertion to verify command availability in PATH |
libs/core/test/assert_eventually |
Assertion for async operations with timeout and retry logic |
libs/core/test/prep_step |
Utility for test setup/teardown steps with distinct visual feedback |
libs/user/tests/get_home/test |
Example test demonstrating the testing framework usage |
docs/TESTING.md |
Comprehensive testing documentation covering framework usage and best practices |
README.md |
Updates to highlight the new testing framework feature |
.github/workflows/test.yaml |
CI workflow to automatically test all functions with test coverage |
.github/workflows/package.yaml |
Modified to run tests before publishing packages and skip packages with test failures |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 12 comments.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
π What
Add test-suite.
Add test workflow.
Add test workflow to package workflow to not publish packages with failed tests.
β Why
β‘ How to Review
β Testing