🐛 Fix assert_exit_code, improve exit code handling for all

[DanielRuthardt]

📑 What

Fix exit code and options handling in core::test::assert_exit_code.
Improve exit code and options handling in all similar assert functions.

❓ Why

As tests are getting added, tests that use core::test::assert_exit_code, all assert functions need to work reliably.

⚡ How to Review

✅ Testing

• I have tested my work
• I need you to test it too

[Copilot]

Pull Request Overview

This PR fixes critical bugs in exit code handling for test assertion functions (assert_success, assert_failure, and assert_exit_code) and improves their reliability when used with shell option set -e.

Key Changes:

• Fixed incorrect exit code capture logic that was broken in the old implementations (exit codes were being captured from the wrong commands)
• Added proper set -e option handling to prevent premature script termination when assertions run commands that may fail
• Applied consistent implementation pattern across all three assertion functions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
libs/core/test/assert_success	Fixed exit code capture and added set -e handling to properly test commands that should succeed
libs/core/test/assert_failure	Fixed exit code capture and added set -e handling to properly test commands that should fail
libs/core/test/assert_exit_code	Added set -e handling to properly test commands with specific exit codes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.