✅ Add tests for most functions #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for user and file manipulation functions in a bash library. The tests validate various edge cases and have already helped identify bugs that existed for months or years.
Key changes:
- Added tests for user functions:
get_uid,get_shell,get_groups, andget_gid - Added tests for file functions:
is_world_writable,is_world_readable,is_world_executable,is_world_accessible,inherit_owners,copy_owners, andcopy - Improved existing
get_hometest with consistent variable naming and simplified logic
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/user/tests/get_uid/test | Tests user ID retrieval for explicit users, current user, environment variable, and custom users |
| libs/user/tests/get_shell/test | Tests shell retrieval for various user scenarios |
| libs/user/tests/get_home/test | Refactored with consistent naming (sudoCommand) and simplified current user test |
| libs/user/tests/get_groups/test | Tests group membership retrieval for single and multiple groups |
| libs/user/tests/get_gid/test | Tests group ID retrieval with complex setup for custom GID |
| libs/file/tests/is_world_writable/test | Tests world-writable permission detection across various permission modes |
| libs/file/tests/is_world_readable/test | Tests world-readable permission detection across various permission modes |
| libs/file/tests/is_world_executable/test | Tests world-executable permission detection across various permission modes |
| libs/file/tests/is_world_accessible/test | Tests accessibility checks for files and directories with nested structures |
| libs/file/tests/inherit_owners/test | Tests ownership inheritance from parent directories |
| libs/file/tests/copy_owners/test | Tests ownership copying between files and directories |
| libs/file/tests/copy/test | Tests file and directory copying with ownership preservation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 What
Add tests for most functions.
❓ Why
The test have already helped (before this PR got created) to identify and fix various issues that have been in functions for months and years. Testing is critical in functional programming.
⚡ How to Review
✅ Testing