Skip to content

Small step towards VR sunflares #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonnyOThan wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Small step towards VR sunflares #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scatterer/Effects/SunFlare/SunFlare.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void start()

public void updateProperties()
{
sunViewPortPos = Scatterer.Instance.scaledSpaceCamera.WorldToViewportPoint (sourceScaledTransform.position);
sunViewPortPos = Scatterer.Instance.scaledSpaceCamera.WorldToViewportPoint (sourceScaledTransform.position, Camera.current.stereoActiveEye);
hitStatus=false;

if (sunViewPortPos.z > 0)
Expand Down Expand Up @@ -225,6 +225,11 @@ public void updateProperties()
hitStatus=false;
}

// For whatever reason, calling SetVector on the material doesn't work for the right eye in VR
// but calling Shader.SetGlobalVector does (note OnPreRender is called for each eye)
// However this will probably break situations where more than one star has an active lens flare
// so I don't want to enable that by default.
// Shader.SetGlobalVector(ShaderProperties.sunViewPortPos_PROPERTY, sunViewPortPos);
sunglareMaterial.SetVector (ShaderProperties.sunViewPortPos_PROPERTY, sunViewPortPos);

if (!(HighLogic.LoadedScene == GameScenes.TRACKSTATION))
Expand Down
2 changes: 1 addition & 1 deletion scatterer/Effects/SunFlare/SunflareCameraHook.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void OnPreRender()

public void OnPostRender()
{
if(flare)
if(flare && Camera.current.stereoActiveEye != Camera.MonoOrStereoscopicEye.Left)
{
flare.ClearExtinction ();
flare.sunglareMaterial.SetFloat(ShaderProperties.renderOnCurrentCamera_PROPERTY,0.0f);
Expand Down