Add quality of life features to the piano roll #8143

Rolandjg · 2025-11-28T02:50:06Z

Note duplication

Ctrl-D

duplication.mp4

Note flipping

flipping.mp4

Key bind zooming

Ctrl- and Ctrl=

zooming.mp4

…s. Ctrl + and ctrl - will zoom in and out in the piano and automation editor

remove blank line

sqrvrt · 2025-11-28T14:38:51Z

src/gui/editors/AutomationEditor.cpp

+			}
+			break;
+
+		case Qt::Key_Equal:


Why not do these as a QAction too?

We can do that, this just seemed like a more straight forward approach.

Use QKeySequence::ZoomIn and ZoomOut. That solves the issue with different keyboard layouts and platforms. For example, on my keyboard 0=} is the same key, and ?+\ is another key

I experimented with the QKeySequence it does work for zooming out, but doesn't perform how you'd expect for zooming in. Ctrl + = is standard, but QKeySequence::ZoomIn expects Ctrl+Shift + =. Also no QKeySequence for Alt + = and Alt + -

Hm, ok so QKeySequence::ZoomIn doesn't use Ctrl+= on English keyboards...? That's annoying. Check out how Wireshark handles the situation:

https://github.com/wireshark/wireshark/blob/9ff63cab38388920df8f170cf19b61604bb39db6/ui/qt/print_dialog.cpp#L210

regulus79 · 2025-11-28T14:59:21Z

#7873 may be related, at least for the note duplication shortcut.

I am curious, reading the code, it appears that duplicateNotes creates a copy of the selected notes in place, right where they are. If I understand correctly, is that the same thing that shift-dragging on a selection does? I could see how that would be useful for keyboard users.

I am also interested what the use-cases are for vertically flipping a selection of notes. Given how scales are usually not evenly spaced, flipping a set of notes would easily create some off-scale notes. Actually, maybe that would be kind of cool sometimes.

The key bind zooming sounds cool for keyboard users. I think we have something similar with a mouse shortcut, but having a purely keyboard one is probably a good idea too.

sqrvrt · 2025-11-28T15:06:44Z

some thoughts:

It's usually also a nice QoL to provide Ctrl-0, which in many programs sets zoom to 100%
Vertical zoom could also be done with e.g. Alt prefix when applicable

… and alt 0

Rolandjg · 2025-11-28T19:31:11Z

some thoughts:

* It's usually also a nice QoL to provide `Ctrl-0`, which in many programs sets zoom to 100%

* Vertical zoom could also be done with e.g. Alt prefix when applicable

Great ideas.

Rolandjg · 2025-11-28T19:35:37Z

#7873 may be related, at least for the note duplication shortcut.

I am curious, reading the code, it appears that duplicateNotes creates a copy of the selected notes in place, right where they are. If I understand correctly, is that the same thing that shift-dragging on a selection does? I could see how that would be useful for keyboard users.

I am also interested what the use-cases are for vertically flipping a selection of notes. Given how scales are usually not evenly spaced, flipping a set of notes would easily create some off-scale notes. Actually, maybe that would be kind of cool sometimes.

The key bind zooming sounds cool for keyboard users. I think we have something similar with a mouse shortcut, but having a purely keyboard one is probably a good idea too.

Yes, duplicate notes does act like shift dragging.
I find vertical flipping for make quick call response melodies, just flipping a few notes can make a nice change.
I work primarily on my laptop with a track pad, so having binds for zooming are very nice. Scrolling up and down while holding control is way too fast on a track pad so having binds makes tiny adjustments easy.

Ctrl+0 and alt+0 are already used for setting quantization and note durations, maybe this can be revised later

allejok96 · 2025-11-29T20:39:41Z

Flipping a melody vertically turns major into minor and vice versa, it's pretty cool that it even works

rdrpenguin04 · 2025-11-29T22:10:23Z

I'd almost want to request horizontal flipping; I find myself doing that fairly often

allejok96 · 2025-11-29T22:31:31Z

Shift+R

allejok96 · 2025-11-29T22:56:51Z

src/gui/editors/PianoRoll.cpp

+	const NoteVector selectedNotes = getSelectedNotes();
+	const auto& notes = selectedNotes.empty() ? m_midiClip->notes() : selectedNotes;
+
+	m_midiClip->flipNotes(notes);


I understand that having Clip::flipNotes is neat, but I don't like that you can pass notes from any clip to it (yeah reverseNotes does it too). I'd rather see that the selection happens inside Clip::flipNotes. It's not a deal breaker though... I need a second opinion on this...

allejok96 · 2025-11-29T22:58:42Z

src/gui/editors/PianoRoll.cpp

+	m_midiClip->flipNotes(notes);
+
+	update();
+	getGUI()->songEditor()->update();


Are these update calls needed? Try without. At least the first one should not be needed since the editor connects to Clip::dataChanged

allejok96 · 2025-11-29T23:02:39Z

src/tracks/MidiClip.cpp

+    int min = notes.at(0)->key();
+    int max = notes.at(0)->key();
+
+    for (auto note : notes)
+    {
+        int key = note->key();
+        if (key > max) { max = key; }
+        if (key < min) { min = key; }
+    }
+
+    int sum = min + max;


Suggested change

int min = notes.at(0)->key();

int max = notes.at(0)->key();

for (auto note : notes)

{

int key = note->key();

if (key > max) { max = key; }

if (key < min) { min = key; }

}

int sum = min + max;

auto bounds = boundsForNotes(notes)

int sum = bounds->lowest + bounds->highest;

allejok96 · 2025-11-29T23:07:45Z

src/gui/editors/PianoRoll.cpp

 	}
 }

+void PianoRoll::duplicateNotes()


Like regulus said, there's no need for duplicate since #7873 does that better

I agree, duplicateNotes should be removed in place for #7873

allejok96 · 2025-11-29T23:15:40Z

Scrolling up and down while holding control is way too fast on a track pad

#7941 (just nagging people)

Rolandjg · 2025-12-21T02:19:52Z

I removed note duplication in favor of #7873 (which should really be merged btw). Keyboard zooming still needs work, but should be a feature in my opinion. Vertical flipping is cool, I think it has a place, nice for easily changing from major to minor.

allejok96

I just saw you're using spaces for indentation. You should be using tabs only

allejok96 · 2025-12-21T11:54:53Z

src/tracks/MidiClip.cpp

+    }
+
+    rearrangeAllNotes();
+    emit dataChanged();


Suggested change

emit dataChanged();

emit dataChanged();

Engine::getSong()->setModified();

allejok96 · 2025-12-21T11:57:37Z

src/gui/editors/PianoRoll.cpp

+				int value = m_zoomingXModel.value();
+				m_zoomingXModel.setValue(value + 1);
+			}
+			if (ke->modifiers() & Qt::AltModifier)


Should be else if otherwise ctrl+alt will zoom both

Rolandjg and others added 8 commits November 25, 2025 13:05

add vertical note flipping and change binds

22d8adc

Duplicate button and bind

ea4cf50

new icon

fcb0b11

includes

be65213

duplicate will create notes in the same location as the selected note…

b087694

…s. Ctrl + and ctrl - will zoom in and out in the piano and automation editor

naming consistency

e9a8efc

revert keybind change

f29a417

style fix

927e6a4

remove blank line

sqrvrt reviewed Nov 28, 2025

View reviewed changes

Add verticle zooming with alt = and alt -, add zoom reset with ctrl 0…

94794e2

… and alt 0

Rolandjg added 2 commits November 28, 2025 19:23

Add zooming functionality to other editors, remove colliding binds

ffcd827

Ctrl+0 and alt+0 are already used for setting quantization and note durations, maybe this can be revised later

Add break so ctrl+0 doesn't go to default

63e2548

allejok96 suggested changes Nov 29, 2025

View reviewed changes

Rolandjg added 2 commits November 30, 2025 00:15

simplify flip notes function

12123ad

remove unnecessary updates

2936731

messmerd changed the title ~~Add quality of life features. Duplication (ctrl-d), zooming with ctrl - and ctrl =, vertical flipping of notes in piano roll.~~ Add quality of life features to the piano roll Dec 3, 2025

Rolandjg and others added 2 commits December 3, 2025 14:38

remove blank line

85ca153

remove note duplication. LMMS#7873 does it better

76a67cd

allejok96 suggested changes Dec 21, 2025

View reviewed changes

	emit dataChanged();
	emit dataChanged();
	Engine::getSong()->setModified();

Uh oh!

Add quality of life features to the piano roll #8143

Are you sure you want to change the base?

Add quality of life features to the piano roll #8143

Uh oh!

Conversation

Rolandjg commented Nov 28, 2025 • edited by messmerd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Note duplication

Note flipping

Key bind zooming

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allejok96 Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

regulus79 commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sqrvrt commented Nov 28, 2025

Uh oh!

Rolandjg commented Nov 28, 2025

Uh oh!

Rolandjg commented Nov 28, 2025

Uh oh!

allejok96 commented Nov 29, 2025

Uh oh!

rdrpenguin04 commented Nov 29, 2025

Uh oh!

allejok96 commented Nov 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allejok96 commented Nov 29, 2025

Uh oh!

Rolandjg commented Dec 21, 2025

Uh oh!

allejok96 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rolandjg commented Nov 28, 2025 •

edited by messmerd

Loading

allejok96 Dec 21, 2025 •

edited

Loading

regulus79 commented Nov 28, 2025 •

edited

Loading