Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the datetime node so it returns a prompt containing the current date/time at execution time (instead of a static timestamp captured at initialization).
Changes:
- Refactors
DateTimeNodeto generate the date/time prompt dynamically on invocation. - Updates unit tests to validate the refreshed prompt behavior.
- Adds a NEXT changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| assistant_core/builder/datetime.py | Changes the datetime node implementation to compute the prompt at call time. |
| tests/unit/test_datetime_builder.py | Updates tests to check the node output content and adds a “refresh” test. |
| CHANGELOG.md | Documents the datetime node fix under NEXT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix datetime node returned time. Previous implementation was returning always the same date, this fixes the prompt to always return the current time.
Type of change
Checklist
Please run through the checklist and mark the items off before requesting review.