Skip to content

Add app tokens#81

Merged
andres-javier-lopez merged 7 commits intomainfrom
app-access-token
Apr 19, 2025
Merged

Add app tokens#81
andres-javier-lopez merged 7 commits intomainfrom
app-access-token

Conversation

@andres-javier-lopez
Copy link
Collaborator

No description provided.

@andres-javier-lopez andres-javier-lopez marked this pull request as ready for review April 19, 2025 16:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for app tokens by introducing a new input model and associated endpoints, as well as a CLI command for generating app tokens.

  • Introduces the PhoneTokenInput model in token.py
  • Adds create_app_token function in token.py and new endpoints in endpoints.py
  • Implements a new CLI command generate_app_token and updates the main CLI commands

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
taskmaster/auth/token.py Added PhoneTokenInput and create_app_token function
taskmaster/auth/endpoints.py Added endpoints for app token refresh and user token
taskmaster/auth/cli.py Added CLI command to generate an app token
taskmaster/main.py Registered new CLI command
CHANGELOG.md Updated changelog with app token validation entry
Comments suppressed due to low confidence (2)

taskmaster/auth/endpoints.py:180

  • [nitpick] Assigning token.scopes to app_token.username may be unclear; consider using a static identifier such as 'app-token' or using phone_token_input.username if that reflects the intended behavior.
token.scopes = [app_token.username]

taskmaster/auth/cli.py:45

  • [nitpick] The local variable 'refresh_token' is used to store an app token; consider renaming it to 'app_token' to more accurately reflect its purpose.
refresh_token = create_app_token(token,)

@andres-javier-lopez andres-javier-lopez merged commit 1b2a3ad into main Apr 19, 2025
2 checks passed
@andres-javier-lopez andres-javier-lopez deleted the app-access-token branch April 19, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants