Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for app tokens by introducing a new input model and associated endpoints, as well as a CLI command for generating app tokens.
- Introduces the PhoneTokenInput model in token.py
- Adds create_app_token function in token.py and new endpoints in endpoints.py
- Implements a new CLI command generate_app_token and updates the main CLI commands
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| taskmaster/auth/token.py | Added PhoneTokenInput and create_app_token function |
| taskmaster/auth/endpoints.py | Added endpoints for app token refresh and user token |
| taskmaster/auth/cli.py | Added CLI command to generate an app token |
| taskmaster/main.py | Registered new CLI command |
| CHANGELOG.md | Updated changelog with app token validation entry |
Comments suppressed due to low confidence (2)
taskmaster/auth/endpoints.py:180
- [nitpick] Assigning token.scopes to app_token.username may be unclear; consider using a static identifier such as 'app-token' or using phone_token_input.username if that reflects the intended behavior.
token.scopes = [app_token.username]
taskmaster/auth/cli.py:45
- [nitpick] The local variable 'refresh_token' is used to store an app token; consider renaming it to 'app_token' to more accurately reflect its purpose.
refresh_token = create_app_token(token,)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.