Fix the hardcoded propID variable to version dependent propID.#289
Open
Fix the hardcoded propID variable to version dependent propID.#289
propID variable to version dependent propID.#289Conversation
Actually introduced new static method `get_propIDVals` making the former `propIDVals` method defunkt. A name change was useful and I fixed this in the new method. The old one has not been removed but probably could be. TODO: - remove the old function - Check the method `get_propIDDict` which does not seem to use OpSimVars and hopefully update it. - Check the number of methods that can be removed. Fixes #288 modified: opsimsummary/opsim_out.py modified: opsimsummary/version.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually introduced new static method
get_propIDValsmaking theformer
propIDValsmethod defunkt. A name change was useful and Ifixed this in the new method. The old one has not been removed but
probably could be.
TODO:
remove the old function
Check the method
get_propIDDictwhich does not seem to use OpSimVarsand hopefully update it.
Check the number of methods that can be removed.
modified: opsimsummary/opsim_out.py
modified: opsimsummary/version.py
Fixes #288