Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

The recent FileLike refactor broke the BiologicsReportTest by offering up R output files that didn't actually get generated. We've been creating 0 byte output files and then opt not to serve them to the client. This restores that behavior. As a followup, we might avoid creating these files in the first place.

Changes

  • Restore check that sees if file exists and has content
  • Misc code cleanup

Tasks 📍

Copy link
Contributor

@labkey-alan labkey-alan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but as you noted, it does seem odd that we're even creating empty files.

@labkey-jeckels labkey-jeckels merged commit fc41c88 into develop Dec 8, 2025
10 of 11 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_fileLike3_rFixes branch December 8, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants