Open
Conversation
Added support for folder-recursive RARC importing in bulk via command line or drag-and-drop.
LagoLunatic
reviewed
Jul 30, 2024
Added more info to the error message when a RARC file is invalid, added the swallow_assertion_errors argument to recursion, and correctly capitalized a comment.
Remove exceptions for files in HomeBTN files, reword, capitalize, and clarify a few comments.
Remove ".arc" extension filter from RARC decompression loop, catch UnicodeDecodeErrors raised by invalid RARC files, update several comments, and update a print statement to match.
Fix a bug where exceptions were not properly caught, fix a bug where exceptions cause termination of the loop, and add a total item counter for comparison between files de-RARC'd and total files attempted.
Fix item_counter and total_item_counter recursion bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for folder-recursive RARC import and unpack in bulk via command line or drag-and-drop, because of my own difficulty in decompiling Twilight Princess' many files. Related to #18.