calculateItemsInView - Don't return early if sticky index changed#381
Open
MPiccinato wants to merge 1 commit intoLegendApp:mainfrom
Open
calculateItemsInView - Don't return early if sticky index changed#381MPiccinato wants to merge 1 commit intoLegendApp:mainfrom
MPiccinato wants to merge 1 commit intoLegendApp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed
onStickyHeaderChangewas not being called when scrolling slowly or just sometimes not at all.The early return optimization check wasn't taking the sticky header index change into consideration so the check to make the call back to
onStickyHeaderChangewas never hit.