fix: Clear stale size caches on data change#391
fix: Clear stale size caches on data change#391LeviWilliams wants to merge 3 commits intoLegendApp:webfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4195e0593b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
First off thanks for all the work on the library, v3 is looking great 🚀
While testing the beta in our app I ran into blanking behaviour in a paginated list where data can shrink and grow again with items that contain the same keys. By simply clearing the size caches for stale keys when data changes I was able to resolve the problem. I'm sure you might have a more elegant solutions but this fixed the issue for me.
This might not be related to only v3 but just aimed at this branch anyways.
before.fix.mov
after.fix.mov