Improve columns behavior, add overrideItemLayout for fixed sized lists and column spanning#88
Draft
jmeistrich wants to merge 4 commits intomainfrom
Draft
Improve columns behavior, add overrideItemLayout for fixed sized lists and column spanning#88jmeistrich wants to merge 4 commits intomainfrom
jmeistrich wants to merge 4 commits intomainfrom
Conversation
Contributor
|
@jmeistrich I see quite big error when using initialScrollIndex+maintainVisibleContentPosition, will try to create repro PR. |
…items in view decreased because of item sizes changing
|
Friendly ping on this — I'd love to be able to use overrideItemLayout 🙏 |
Contributor
|
@stevengoldberg thanks for bringing that issue up, there are couple of complications making overrideItemLayout work without breaking maintainVisibleContentPosition mode, hopefully will be able to fix that soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@michbil Can you check this over and see if it looks good to you, especially with getting the row height when anchoring?