Fix persisting null with ObservablePersistMMKV#381
Open
simontreny wants to merge 1 commit intoLegendApp:mainfrom
Open
Fix persisting null with ObservablePersistMMKV#381simontreny wants to merge 1 commit intoLegendApp:mainfrom
simontreny wants to merge 1 commit intoLegendApp:mainfrom
Conversation
aa28e7d to
32cba1a
Compare
simontreny
commented
Oct 31, 2024
| try { | ||
| storage.set(table, safeStringify(v)); | ||
| if (v !== null) { | ||
| storage.set(table, safeStringify(v)); |
Author
There was a problem hiding this comment.
On second thought, I think the root issue is how safeStringify() is implemented:
return value ? JSON.stringify(value, replacer) : value;
It means that if the value is false (false, 0, "" or null), it won't be serialized as a string. If this called JSON.stringify() directly, this would work properly as null would be serialised "null" which can be saved and restored with MMKV.
I'm not sure I understand the intent of safeStringify(), I would expect it to always return either a string or undefined.
Author
There was a problem hiding this comment.
It probably also means that persisting 0 (or false) is broken too, as it will be persisted as a number but we will attempt to restore it with storage.getString()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes persisting
nullvalues in observable when usingObservablePersistMMKV.Consider this piece of code:
This logs the following error:
and the old value is restored on next launch.
This happens because the persist plugin tries to call
storage.set(null)while it's not supported byreact-native-mmkv