feat: directive $observe to wrap component in a Memo#402
Open
misaeldossantos wants to merge 2 commits intoLegendApp:mainfrom
Open
feat: directive $observe to wrap component in a Memo#402misaeldossantos wants to merge 2 commits intoLegendApp:mainfrom
misaeldossantos wants to merge 2 commits intoLegendApp:mainfrom
Conversation
Member
|
I experimented with something like this in the beginning but it felt too different from regular React. It makes it harder to document best practices when a feature depends on a build pipeline that not everyone uses, and it adds more surface area for bugs and support. So I don't think we want to build this into the core, at least for now. But I do think it's very cool! Would you like to create it as a separate package and we could link to it in the docs? I'd feel more comfortable linking to it and talking about it as a cool thing you made, outside of the core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I created a babel plugin to automatically wrap components in a just by adding the $observe directive to any jsx tag where you want to observe (I originally created it for mobx, then I adapted it for legend state, it worked the same way).
Example:
Babel transforms it to
It is identical to the plugin that already exists (https://legendapp.com/open-source/state/v3/react/fine-grained-reactivity/#optionally-add-the-babel-plugin), but without needing to wrap the components in a Memo, just adding a new prop to the component ($observe)