Array Handling in Legend-State: Add ability for shallow and deep compare of arrays#564
Open
mkuczera wants to merge 1 commit intoLegendApp:mainfrom
Open
Array Handling in Legend-State: Add ability for shallow and deep compare of arrays#564mkuczera wants to merge 1 commit intoLegendApp:mainfrom
mkuczera wants to merge 1 commit intoLegendApp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We stumbled upon a case where the observable was not reflecting the synced changes. In the specific case a query was not properly updating beside having received the correct payload from the network request. Our response was containing an array of items. On removal of an item the deepMerge was performing updates on the rest of the elements and not removing the intended item.
Proposal
When working with arrays in reactive applications, the way arrays are merged significantly affects performance and behavior. This proposal makes the handling of arrays configurable and prevents common issues like unwanted index-based merging while optimizing for performance. If this implementation is fine i can add the corresponding documentation also.
Configuration Options
arrayHandlingOptions'never''shallow''deep'Usage Examples
1. Sync Operations
TanStack Query
Other Sync Plugins
1. Global Configuration
Set default behavior for all sync operations:
Common Patterns
API Data Updates
Complex Nested Data