fix(crud): use deepEqual for object change detection#606
Open
BadLice wants to merge 3 commits intoLegendApp:mainfrom
Open
fix(crud): use deepEqual for object change detection#606BadLice wants to merge 3 commits intoLegendApp:mainfrom
BadLice wants to merge 3 commits intoLegendApp:mainfrom
Conversation
Compare local and remote object values by deep equality, not reference, when reconciling fields in syncedCrud. Prevents false positives when objects are structurally equal.
BadLice
force-pushed
the
bug/issue-410
branch
from
04512a2 to
8055253
Compare
BadLice
force-pushed
the
bug/issue-410
branch
from
8055253 to
cd40841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
src/sync-plugins/crud.tsto use deep equality (deepEqual) for comparing object values instead of reference comparison insyncedCrud.Summary:
Closes #410.