fix(undoRedo): clear redo stack when using limit option#630
Open
sgup wants to merge 1 commit intoLegendApp:mainfrom
Open
fix(undoRedo): clear redo stack when using limit option#630sgup wants to merge 1 commit intoLegendApp:mainfrom
sgup wants to merge 1 commit intoLegendApp:mainfrom
Conversation
When the `limit` option was set, making a change after undoing would not clear the redo stack. This caused history corruption where undone states would persist and could be incorrectly restored. The fix ensures redo history is always cleared first (by slicing to historyPointer + 1), then the limit is applied separately. Before: - limit set: history.slice(Math.max(0, history.length - limit)) - no limit: history.slice(0, historyPointer + 1) After: - always: history.slice(0, historyPointer + 1) // clear redos - if limit: history.slice(Math.max(0, history.length - limit)) // apply limit Added regression test to verify the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the
limitoption is set onundoRedo(), making a change after undoing does not clear the redo stack. This causes history corruption where undone states persist and can be incorrectly restored.Steps to reproduce:
undoRedo(obs$, { limit: 10 })Root Cause
The original code had mutually exclusive branches:
Solution
Always clear redo history first, then apply the limit separately:
Testing
Added regression test
'Undo/Redo with limit clears redo stack on new change'that verifies the fix.All existing tests pass.