Skip to content

Fix code issues & Add comments #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jackjyzhang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix code issues & Add comments #8

jackjyzhang wants to merge 3 commits into from

Conversation

@jackjyzhang
Copy link

@jackjyzhang jackjyzhang commented Nov 17, 2021

Changes:

  • Eliminate Bar in utils and use the progress package instead
  • Eliminate the global state variable, which was causing problems, and create relevant workarounds
  • Fix issue related to view/reshape in eval.py
  • Add overall comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jackjyzhang