Autoscale widgets with CSS calc() - extra work? #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a couple changes to line 102; no value conversion has yet occurred, only formatting changes.
No values have yet been converted; only display format has been altered.
No values have yet been converted; only formatting has been altered.
No values have yet been converted; only formatting has been altered.
No values have yet been converted; only display format has been altered.
Ideally, ht_utils_layers.js should now be able to access pg_flex_w directly.
ht_utils_layers.js should now have direct access to pg_min_w
Note: this may not work properly if the min-width of the current pane has not already been set.
This reverts commit 575d743.
Revert "Changed pixel formatting cues to percentage"
Changed percentage cues back to pixel format
Converted percentage formatting back to pixel format
Removed a line of code originally meant to ensure that changes to the code were appearing in the final output.
Changed percentage formatting cues back to pixel format
Reverted percentage formatting back to pixel format, and removed the unnecessary and problematic variable mw.
Declared some new variables to see whether their mere presence upsets the balance of things.
Added some functions to initialize the variables declared last round, and added some corresponding functionality to the htrAddStylesheetItem calls.
Removed some stray references to a variable I replaced in the last commit.
Added a snippet of code to narrow down the possible issues that may have prevented the last commit from working properly.
Turns out they're not necessary
Turns out you need to include the stdbool library to use the bool variable type in C. Also, I forgot to declare firstbornWidth before using it.
The function isMainContainer() was used before it was declared.
Removed references to min-width and min-height; doubled the influence of box_offset in an effort to resolve the overexpansion issue that's just arisen.
Before, it was defaulting to zero, which nullified the part of calc() that accounted for spacing.
Reverted default box_offset value to 0 and converted the bool variables I'd added to integers.
Previously was determined by box_offset, which is more a flag than a value
…ight for consistency" This reverts commit 2281f87.
Also remedied an inconsistency in calc()
…detector" This reverts commit 4ce532f.
…r main containers" This reverts commit 3f7774d.
Replaced a hard-coded value with a soft-coded one
Contributor
|
This work seems to be incomplete. Additionally, there appear to be several compiler errors that would need to be addressed. However, the concept of a "MainContainer" might be useful, but I can't find much explanation of what a "MainContainer" is, or why it should get special treatment in the layout. I'm likely just misunderstanding what the team was going for here, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #25
This work is related to the autoscaling project, but I'm not sure precisely how.