Db name changes #66
Open
Db name changes #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng end ptr for the last key
gbeeley
requested changes
Apr 5, 2024
Member
gbeeley
left a comment
gbeeley
left a comment
There was a problem hiding this comment.
A few changes; I think it's fine to keep the structure as-is, as opposed to modifying the cached values and regenerating the name. Either way we'd be surgically replacing something that's normally auto-generated.
…anged how datetimes are added to path names.
…. Enabled sybase to properly set datetime cols that are part of primary keys
…les it internally
Contributor
Author
|
This branch should be ready for merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially decided directly modifying the name string was the simplest approach. I now wonder if modifying the cached key values and having it re-generate the name might be cleaner and less error prone (especially since we don't escape | and /).