Skip to content

Cache required capabilities #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LinqLover wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cache required capabilities #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/SimulationStudio-Base.package/Simulator.class/class/cleanUp.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
initialize-release
cleanUp

self cleanUpContextClasses.
self cleanUpContextClasses.
self cleanUpRequiredCapabilities.
6 changes: 6 additions & 0 deletions packages/SimulationStudio-Base.package/Simulator.class/class/cleanUpRequiredCapabilities.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
context classes
cleanUpRequiredCapabilities

requiredCapabilities := nil.
self allSubclassesDo: [:simulatorClass |
simulatorClass cleanUpRequiredCapabilities].
2 changes: 2 additions & 0 deletions packages/SimulationStudio-Base.package/Simulator.class/class/noteAddedSelector.meta..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ noteAddedSelector: selector meta: isMeta

super noteAddedSelector: selector meta: isMeta.

self cleanUpRequiredCapabilities.

self flag: #todo. "Is this the right hook? There is also #noteCompilationOf:meta: ..."
self allSubInstances ifNotEmpty: [
Transcript showln: ('You should restart all {1} subinstances now to apply the changes to {2}.' format: {self. selector})].
8 changes: 8 additions & 0 deletions packages/SimulationStudio-Base.package/Simulator.class/class/requiredCapabilities.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
context classes
requiredCapabilities

^ requiredCapabilities ifNil: [requiredCapabilities :=
((Pragma allNamed: #capability: from: self to: Simulator)
reject: [:pragma |
(self lookupSelector: pragma selector) methodClass == pragma methodClass])
collect: [:pragma | pragma argumentAt: 1] as: Set]
5 changes: 1 addition & 4 deletions packages/SimulationStudio-Base.package/Simulator.class/instance/requiredCapabilities.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,4 @@ context classes
requiredCapabilities
"Override this and answer nil to disable optimized capabilities."

^ ((Pragma allNamed: #capability: from: self class to: thisContext methodClass)
reject: [:pragma |
(self class lookupSelector: pragma selector) methodClass == pragma methodClass])
collect: [:pragma | pragma argumentAt: 1] as: Set
^ self class requiredCapabilities
8 changes: 5 additions & 3 deletions packages/SimulationStudio-Base.package/Simulator.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
{
"class" : {
"basicContextClass" : "ct 11/12/2021 18:36",
"cleanUp" : "ct 11/12/2021 19:40",
"cleanUp" : "ct 2/4/2022 00:35",
"cleanUpContextClasses" : "ct 11/12/2021 19:39",
"cleanUpRequiredCapabilities" : "ct 2/4/2022 00:35",
"contextClassForCapabilities:" : "ct 11/13/2021 21:12",
"contextClassForSimulators:" : "ct 11/12/2021 18:36",
"debug:" : "ct 11/13/2021 15:46",
"decorating:" : "ct 11/11/2021 21:47",
"evaluate:" : "ct 11/11/2021 22:07",
"fullContextClass" : "ct 11/12/2021 18:36",
"noteAddedSelector:meta:" : "ct 11/13/2021 20:13",
"noteAddedSelector:meta:" : "ct 2/4/2022 00:35",
"requiredCapabilities" : "ct 2/4/2022 00:40",
"warmUp" : "ct 11/12/2021 19:40",
"warmUpContextClasses" : "ct 11/12/2021 19:40" },
"instance" : {
Expand Down Expand Up @@ -68,4 +70,4 @@
"initializeContext:" : "ct 11/13/2021 00:19",
"nextSimulator" : "ct 11/11/2021 21:47",
"nextSimulator:" : "ct 11/11/2021 21:47",
"requiredCapabilities" : "ct 11/13/2021 22:11" } }
"requiredCapabilities" : "ct 2/4/2022 00:31" } }
2 changes: 1 addition & 1 deletion packages/SimulationStudio-Base.package/Simulator.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"category" : "SimulationStudio-Base",
"classinstvars" : [
],
"requiredCapabilities" ],
"classvars" : [
"ContextClasses" ],
"commentStamp" : "ct 11/13/2021 17:08",
Expand Down
3 changes: 3 additions & 0 deletions ...ges/SimulationStudio-Base.package/SimulatorContext.class/class/noteAddedSelector.meta..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@ noteAddedSelector: selector meta: isMeta
(Simulator respondsTo: #cleanUpContextClasses) ifTrue: [
"don't fail while checking out the package via Squot"
Simulator cleanUpContextClasses].
(Simulator respondsTo: #cleanUpRequiredCapabilities) ifTrue: [
"don't fail while checking out the package via Squot"
Simulator cleanUpRequiredCapabilities].
Simulator allSubInstances ifNotEmpty: [
Transcript showln: ('You should restart all simulators now to apply the changes to {1}>>{2}.' format: {self. selector})].
2 changes: 1 addition & 1 deletion packages/SimulationStudio-Base.package/SimulatorContext.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"class" : {
"noteAddedSelector:meta:" : "ct 12/27/2021 01:39" },
"noteAddedSelector:meta:" : "ct 2/12/2022 15:29" },
"instance" : {
"activateMethod:withArgs:receiver:" : "ct 11/13/2021 15:57",
"blockReturnConstant:" : "ct 11/13/2021 15:13",
Expand Down