Fixes regarding external assembly references which cannot be resolved#177
Open
mjgertsen wants to merge 2 commits intoLokad:masterfrom
Open
Fixes regarding external assembly references which cannot be resolved#177mjgertsen wants to merge 2 commits intoLokad:masterfrom
mjgertsen wants to merge 2 commits intoLokad:masterfrom
Conversation
…assembly is an assemblybuilder
…part of the assembly itself were not working.
The GetCustomAttribute would fail because it is unable to resolve the reference for the provided type.
Using the AssemblyQualifiedname will make sure the reference can be resolved.
Example:
[AnAttribute(typeof(TypeFromOtherAssembly))]
public class test {
}
Trying to get the custom attribute will result in an unable to resolve "TypeFromOtherAssembly" exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When saving an assemblybuilder to file I had two issues.
First one was a reference which could not be found when a type of a references assembly was passed as a parameter of an customattribute.
Second one that I had was that the IsReferencedType method was always returning false.
Therefore I got an exception that the referenced assembly (the one that was being saved) could not be found.