Skip to content

Conversation

@AngRodrigues
Copy link
Member

@AngRodrigues AngRodrigues commented Nov 24, 2024

  • also adds back the linting actions to ci

@AngRodrigues AngRodrigues mentioned this pull request Nov 24, 2024
13 tasks
@lachlangrose
Copy link
Member

Looks good, my only comment is this breaks how LS reads the projectfile for stratigraphic thicknessses. I can make some changes to LS to make this work but I think there needs to be a variable in the projectfile to indicate which thickness is to be used. Maybe in the thicknessCalculator element there could be a boolean flag to say whether it is active or not, although we need to make sure only one is active!

@AngRodrigues
Copy link
Member Author

AngRodrigues commented Nov 26, 2024

Looks good, my only comment is this breaks how LS reads the projectfile for stratigraphic thicknessses. I can make some changes to LS to make this work but I think there needs to be a variable in the projectfile to indicate which thickness is to be used. Maybe in the thicknessCalculator element there could be a boolean flag to say whether it is active or not, although we need to make sure only one is active!

Yeah, I can understand that. This would come from map2loop.
Thinking about implementing this,

  • How about the user can define this flag with something like proj.set_loopstructural_thickness(InterpolatedStructure),
  • or if not defined, flag the first calculator in the list.

@lachlangrose Would you agree with this?

@lachlangrose
Copy link
Member

yeah sounds perfect. I would call the function set_active_thickness and the default active thickness is the label of the first thickness calculator in the list.

Also add option to ElementToDataframe to use headers columns provided and return a specific number of columns.
These can be set using setncattr method for the group.
If headers is included these will be used for the dataframe headers.
If ncols is included this will return df.iloc[:,:ncols]
lachlangrose and others added 10 commits November 29, 2024 15:04
Also add option to ElementToDataframe to use headers columns provided and return a specific number of columns.
These can be set using setncattr method for the group.
If headers is included these will be used for the dataframe headers.
If ncols is included this will return df.iloc[:,:ncols]
@AngRodrigues AngRodrigues merged commit 7641e2e into master Dec 12, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants