-
Notifications
You must be signed in to change notification settings - Fork 4
fix: added thickness calculator fields #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good, my only comment is this breaks how LS reads the projectfile for stratigraphic thicknessses. I can make some changes to LS to make this work but I think there needs to be a variable in the projectfile to indicate which thickness is to be used. Maybe in the thicknessCalculator element there could be a boolean flag to say whether it is active or not, although we need to make sure only one is active! |
Yeah, I can understand that. This would come from map2loop.
@lachlangrose Would you agree with this? |
|
yeah sounds perfect. I would call the function set_active_thickness and the default active thickness is the label of the first thickness calculator in the list. |
Also add option to ElementToDataframe to use headers columns provided and return a specific number of columns. These can be set using setncattr method for the group. If headers is included these will be used for the dataframe headers. If ncols is included this will return df.iloc[:,:ncols]
Also add option to ElementToDataframe to use headers columns provided and return a specific number of columns. These can be set using setncattr method for the group. If headers is included these will be used for the dataframe headers. If ncols is included this will return df.iloc[:,:ncols]
…ctFile into fix_thicknesses
Uh oh!
There was an error while loading. Please reload this page.