SIGTERM and SIGINT handler in PySide event loop #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: README.md
…n in `CHANGELOG.md`
It was really important because if someone does not link .desktop with icon then the icon would not work.
There was a mistake in installation instructions
… messing up execution of program.
1. Reformatted all links and images to be in Markdown. 2. Fixed instructions to be more user-friendly.
README fix
Add link to binary packages in README.md
Rephrased description, modified formatting, removed contributors from README.md, will be inserted in future About window.
Also fixes about dialog.
Contains import fix, from os import system, about fix.
Installation instructions updated.
Included description for available download options.
Align text prettily
-> now can save settings -> now can load settings as well! -> small fix in UI
Following the instructions of GPL -> each source file now contains copy right notice -> separate license file -> separate GPL license file
It was updated to 1.2.3
* Creation of default file location in ~/.config * Save temperature along with brightness settings * Preparation for minimize to system tray
Edited contributors and version number
Feature: Close to systemtray - verify quit
Create CODE_OF_CONDUCT.md
…anges Tray improvements and fixes, QTSingleApplication impl.
Update version no. to 2.2
Owner
|
Checked, still canceling the shutdown. |
Owner
|
@jahan-addison if possible, set up a Kubuntu in VM and test by yourself to see how the signal is getting canceled. Will make the whole testing thing easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information on this PR: https://stackoverflow.com/a/4939113
The application now listens to
SIGTERMandSIGINT.We use
QTimerto allow thePySideevent loop to listen to signals in the python interpreter, such as shutting down.Can someone test this? /cc @LordAmit