App now gets display names from display EDID #253
Conversation
sets the correct connection for xrandr in self.displays. self.displays now is a nested array contaning the connection and the monitor name (ex: ["dp-1", "monitor"])
Soggy-Pancake
changed the title
|
Hey! Thanks for the pull request and for addressing #220 ! Right now, I do not have a Linux machine to test this. @archisman-panigrahi , can you please help me by taking a look at it? Since the import statements changed a bit, your scripts to build packages might break, so I want your attention on this part! |
monitor name extraction fails
|
I just added a protection for when the display doesnt give EDID or the name cant be found for some reason. It will fall back to the connection name (ex. DP-0) if the name extraction fails for any reason. |
|
Sorry about the delay responding. I will review it this weekend.
The ddcutil version is not in PPA because I am yet to figure out how to package this new version. |
…up ["connection name", "display name"]
…ent combo boxes being filled with the original xrandr screen order. I also fixed the display update to respect combo box selections as well as updating display sliders after changing either combo box.
… doesnt give edid anymore.
… names are now gotten on wayland! DDC control now functions on both x11 and wayland.
|
Wayland crashes have been fixed as I just managed to get wayland working yesterday. The original software brightness doesn't work on Wayland but ddc now will. |
make this a ui popup instead of only in the terminal, but at least there will be a more definitive way of telling if users are on wayland.
…ill be disabled if it is a laptop display and there is another check in the setBrightness function as well just in case. The subprocess.run is now also wrapped in a try block as a last resort.
3 participants
The app now sets the correct connection for xrandr in self.displays. self.displays now is a nested array contaning the connection and the monitor name (ex: ["dp-1", "monitor"]), which should solve #220.
I also fixed the imports as it would crash upon trying to import anything under brightness_controler_linux as the init.py had been moved to the same folder some time back.