Skip to content

Conversation

@albertodebortoli
Copy link
Member

Pull Request Title

#11 created a mock for Noorable to avoid printing when running tests. This proved to not be enough as the Noorable's format method returns a string that is eventually used by the print method, resulting in empty logs.

This PR puts Noora behind a layer (Printer) and the tests now use the corresponding mock (PrinterMock) to avoid printing anything at all to the console, achieving the original goal of the previous PR.

Type of Change

  • Feature
  • Bug fix
  • Maintenance / Refactor
  • Documentation
  • CI / Tooling
  • Other (specify)

How Has This Been Tested?

Describe the testing strategy and commands executed.

  • Added / updated unit tests
  • Manually tested locally
  • Tested on macOS (arch: arm64 / x86_64)
  • Other

Screenshots / Demo (if applicable)

Add images, logs, or terminal output.

Checklist

  • Swift code builds locally (swift build)
  • Tests pass locally (swift test)
  • Code style / formatting respected
  • Documentation updated (README / comments)
  • Version / tag alignment considered (if release related)
  • PR title follows conventional style (optional)

CI Considerations

  • Affects build time notably
  • Requires new secrets / env vars
  • Alters release process

Breaking Changes?

  • No
  • Yes

@albertodebortoli albertodebortoli added this to the 0.4.0 milestone Jan 4, 2026
@albertodebortoli albertodebortoli merged commit dd588fd into main Jan 4, 2026
1 check passed
@albertodebortoli albertodebortoli deleted the noora-wrap branch January 4, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants