Skip to content

Conversation

@omshinde
Copy link
Contributor

@omshinde omshinde commented Dec 8, 2023

@omshinde omshinde self-assigned this Dec 8, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@omshinde omshinde requested a review from jjfrench December 8, 2023 23:01
@omshinde
Copy link
Contributor Author

Ready for review @jjfrench

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could still put yourself as author at the top :)


Reply via ReviewNB

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the collection we're using? I saw GEDI_CalVal_Lidar_Data___2 is being used below


Reply via ReviewNB

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you running this in the ADE? is this being used somewhere?


Reply via ReviewNB

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap out for pystac item asset href?


Reply via ReviewNB

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the json object supposed to be used somewhere?

What does this value mean? 5657309

Is this needed for anything?

proj_create_from_database: Open of /opt/conda/envs/pdal24/share/proj failed


Reply via ReviewNB

@@ -0,0 +1,438 @@
{
Copy link
Member

@jjfrench jjfrench Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need arrays or log?


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants