Skip to content

Conversation

@grallewellyn
Copy link
Member

@grallewellyn grallewellyn commented Jul 30, 2025

Github Issue: MAAP-Project/Community#1166

Description

We added the OGC endpoints so we needed to add the implementation to maap-py
Added snake case to function calls

Overview of work done

Called all the OGC endpoints added to the API
Note that WPS endpoints and functions will no longer be supported

Overview of verification done

Added test_ogc_functions.py but most testing is done here: https://github.com/MAAP-Project/maap-api-nasa/blob/develop/test/api/endpoints/test_ogc.py

Overview of integration done

Tested in a notebook in DIT

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

sujen1412
sujen1412 previously approved these changes Aug 21, 2025
@sujen1412 sujen1412 self-requested a review January 7, 2026 00:31
sujen1412
sujen1412 previously approved these changes Jan 7, 2026
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@grallewellyn
Copy link
Member Author

@sujen1412 This PR is ready to merge unless we want the register_algorithm_from_cwl_file function to be implemented
I can implement that function next week since I am still handling the s3 mounting issues now

@grallewellyn
Copy link
Member Author

Merging because not much as changed since Sujen's review

@grallewellyn grallewellyn merged commit 712c0fd into develop Jan 16, 2026
2 checks passed
@grallewellyn grallewellyn deleted the add-ogc-endpoints branch January 16, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants