-
Notifications
You must be signed in to change notification settings - Fork 6
Fix quote sort #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix quote sort #754
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 153 153
Lines 6224 6224
=======================================
Hits 5478 5478
Misses 746 746
🚀 New features to boost your workflow:
|
|
Did an oopsie - see #758 for context :) |
ddabble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😊
| migrations.AlterField( | ||
| model_name='quote', | ||
| name='time', | ||
| field=models.DateTimeField(verbose_name='-time it was said'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| field=models.DateTimeField(verbose_name='-time it was said'), | |
| field=models.DateTimeField(verbose_name='time it was said'), |
ddabble
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I forgot: I think you should update the changelog with this fix :)
Proposed changes
Made it so quotes that have the same date are sorted by descending id.
Checklist
(If any of the points are not relevant, mark them as checked)
makemigrations,makemessagesandcompilemessagesmanagement commands and committed any changes that should be included in this PR